address duplicate aesthetic listings in documentation, re #3618 #3657
Conversation
in utilities-help.r::rd_aesthetics_item, split required
aesthetics specified with pipe operator (e.g. "x|y")
into separate items so that they may be excluded from
the list of all aesthetics prior to rendering the
documentation of parameters.
|
Well, damn. lil help ? |
There was a problem hiding this comment.
Looks good! Could you include "Fix #3618" in the description so that the issue will be closed automatically?
c.f. https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords
|
Added to Pull request description. |
Co-Authored-By: Hiroaki Yutani <yutani.ini@gmail.com>
|
Thanks, perfect! I'm merging this but will wait for a while for other comments. |
|
Thanks. When you have a moment, I'd like some more information on how to know whether to ignore the check failures that happened here -- or what I could have done to better prep it. |
|
No worries, it's not your fault. In my rough understanding, codecov complains because this PR adds lines to the location where we don't have any unit tests. You can add tests to improve the test coverage, but I don't think it's worth doing for this documentation-only function. |
|
Merging now. Thanks! |
Fix #3618
My thoughts on approach included in #3618 comments.
Also have concerns about results of
testthatrun, but results are identical to master branch.